swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

[typescript-jquery] Fix promise resolution to adhere to the type annotation

Open grollinger opened this issue 7 years ago • 3 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ ] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [ ] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes #8383

The type annotation that is generated for an API states that the JQueryPromise<...> will be resolved with a single value. The implementation, on the other hand resolves with two.

This changes the implementation to resolve the promise in accordance with the type annotation. It also adds another type specifying what will be passed if the promise is rejected.

grollinger avatar Jul 04 '18 07:07 grollinger

Great @grollinger ! Thanks

baol avatar Jul 06 '18 20:07 baol

@macjohnny , FYI

baol avatar Jul 11 '18 20:07 baol

What's the word on merging this fix in swagger-codegen? Looks like it was already closed in openapi-generator.

rahulbpatel avatar Nov 06 '20 21:11 rahulbpatel