swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

Issue 8221

Open joeboyscout04 opened this issue 7 years ago • 2 comments

PR checklist

  • [X] Read the contribution guidelines.
  • [X] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [X] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [X] Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @ehyche

Description of the PR

I added compatibility for unwrapRequired config option for Swift 4 to fix #8221.

I couldn't get the integration tests to work properly, they keep timing out, but this was happening before I made any changes anyway. Hope we can get a speedy review!

joeboyscout04 avatar May 22 '18 19:05 joeboyscout04

Can I get a maintainer to review and merge this one please?

joeboyscout04 avatar Jun 01 '18 10:06 joeboyscout04

Hey Meat Bag! Your Pull Request Build Passed! 743 tests run, 5 skipped, 0 failed.

swagger-bot avatar Jun 30 '20 23:06 swagger-bot