swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

generate erlang code after opt processing

Open liamjjmcnamara opened this issue 7 years ago • 4 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This is a fix for Issue 8084

I extended the processOpts() method in ErlangServerCodegen.java to contain the (already existing) calls to supportingFiles.add, effectively moving them from the constructor. This causes the supportingFiles.add calls to happen after option processing, and thus causes the code to respect the setting of --additional-properties packageName on the commandline.

@tsloughter

liamjjmcnamara avatar Apr 20 '18 14:04 liamjjmcnamara

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 avatar Apr 21 '18 06:04 wing328

Ah, thanks for catching that, I squashed the commits and relabeled.

liamjjmcnamara avatar Apr 21 '18 09:04 liamjjmcnamara

CI pipeline is failing, but seemingly due to network failures upsetting sbt downloads, rather than failing tests.

liamjjmcnamara avatar Apr 23 '18 06:04 liamjjmcnamara

Is there anything stopping this from being merged?

solvip avatar May 18 '18 11:05 solvip