swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

[PHP] Fix deserialize ApiException as a Model

Open ymilin opened this issue 7 years ago • 2 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

When defining default responses (ApiException) as a Schema Object in Swagger declaration files, the current implementation cannot deserialize the Model properly into ApiException::$responseObject.

Added a check for $returnType and json_decode appropriately (same logic as the try part of same function for success responses)

fix #7544

ymilin avatar Apr 04 '18 14:04 ymilin

@jebentier @dkarlovi @mandrean @jfastnacht @ackintosh

ymilin avatar Apr 04 '18 14:04 ymilin

Thanks for the PR! I'll check it later. 😉

ackintosh avatar Apr 07 '18 10:04 ackintosh