swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

fixed the rewriting models

Open serezha93 opened this issue 8 years ago • 6 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [x] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [x] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixed erasing existing models in "allProcessedModels" if any model has the same names that on in map. Before, in this case, these models had the same position and cause one of them can be erasing. Now we correct position also being guided by model file path.

serezha93 avatar Nov 24 '17 15:11 serezha93

Comrades, why the first test failed?

serezha93 avatar Nov 29 '17 09:11 serezha93

Restarted the CI tests and all green now.

wing328 avatar Dec 11 '17 15:12 wing328

@serezha93 do you mind sharing a spec to reproduce the issue?

wing328 avatar Dec 11 '17 15:12 wing328

@wing328 I can attach a swagger file but where is the best place for this?

serezha93 avatar Dec 11 '17 19:12 serezha93

@serezha93 please send it to my email ([email protected]) or put it on https://gist.github.com.

wing328 avatar Dec 12 '17 02:12 wing328

@serezha93 I probably missed your email. Please send it (the spec) again when you've time.

wing328 avatar Jan 22 '18 13:01 wing328