swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard
verified publisher icon swagger-api

[2152] Do not inject Jackson dependencies - JAX-RS spec client

Open keithchong opened this issue 8 years ago • 7 comments

PR checklist

  • [ ] Read the contribution guidelines.
  • [ ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ ] Filed the PR against the correct branch: master for non-breaking changes and 3.0.0 branch for breaking (non-backward compatible) changes.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

keithchong avatar Aug 11 '17 22:08 keithchong

Two additional notes about the file changes:

a) I did not intentional change these files, but there appears to be two files with conflicting names in samples/client/petstore/typescript-angular2/with-interfaces/model.

apiResponse.ts and ApiResponse.ts

I was not able to keep both when using eGit.

b) Although most of the mustache files are 'similiar' to other libraries, I'd like to more critique on: modules/swagger-codegen/src/main/resources/Java/libraries/jaxrs-spec/ApiClient.mustache. eg. in the serialize method, I made a comment on multipart/form-data. In other libraries, it is supported.

keithchong avatar Aug 14 '17 16:08 keithchong

@keithchong thanks for the PR. I got errors when running mvn test with the Java (jaxrs-spec) petstore client: https://github.com/swagger-api/swagger-codegen/tree/keithchong-2152-DoNotInjectJacksonDependencies-JaxRsSpecClient/samples/client/petstore/java/jaxrs-spec

I wonder if you can take a look to see if you can reproduce the error.

wing328 avatar Aug 30 '17 17:08 wing328

@keithchong do you need help reproducing the issue?

wing328 avatar Oct 03 '17 07:10 wing328

Hi @wing328, it appears that the sample tests for jaxrs-spec are not there, correct?

keithchong avatar Oct 16 '17 15:10 keithchong

@keithchong I manually created the jaxrs-spec petstore samples when testing it. I can recreate that branch tomorrow.

wing328 avatar Oct 16 '17 15:10 wing328

UPDATE: added back the samples in that branch, https://github.com/swagger-api/swagger-codegen/tree/keithchong-2152-DoNotInjectJacksonDependencies-JaxRsSpecClient/samples/client/petstore/java/jaxrs-spec

wing328 avatar Oct 17 '17 14:10 wing328

@keithchong do you need help reproducing the issue?

wing328 avatar Nov 27 '17 09:11 wing328