swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard
verified publisher icon swagger-api

Issue 4805

Open Uebergeek702 opened this issue 8 years ago • 6 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [ ] Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates) : I tried but it didn't work on a Linux Red Hat machine for me.
  • [ ] Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes. : I'm not sure what to do here? Should I merge it against that branches in my forked repository?

Description of the PR

Changes in #4805: - Parameter added : modelGetterSetterNaming. Sames values as modelPropertyNaming - Both parameters now for all languages : Used in DefaultCodegen.java - Tests adjusted

Uebergeek702 avatar Jun 23 '17 10:06 Uebergeek702

Can anyone tell me why the Travis test fails? I looked into the log but that doesn't tell me anything meaningful. Help would be appreciated - when someone can give me a hint I'll do the changes to get that integration test running.

Uebergeek702 avatar Jun 23 '17 12:06 Uebergeek702

@Uebergeek702 don't worry about the CI tests, which could fail due to rating limiting by Github.

I'll take a look and let you know if I've any questions.

Thanks for the contribution.

wing328 avatar Jun 23 '17 13:06 wing328

Ok - thx - when you have any questions mail me or write me here :)

Uebergeek702 avatar Jun 23 '17 14:06 Uebergeek702

I can do the same changes for the 2.3.0 branch too. Should I?

Uebergeek702 avatar Jul 03 '17 14:07 Uebergeek702

I can do the same changes for the 2.3.0 branch too. Should I?

No need. We'll sync the changes from master to 2.3.0 to ensure 2.3.0 also gets the enhancements, bug fixes made to the master.

wing328 avatar Jul 03 '17 14:07 wing328

I am affected by this as well - the status seems a bit unclear to me. What I can see:

  • there are failing tests
  • @wing328 commented not to worry about them
  • there are conflicts
  • there is an open question about MODEL_PROPERTY_NAMING
  • a lot of time has passed since these conversations

@Uebergeek702 do you still have an interest in getting this merged?

christf avatar May 26 '23 11:05 christf