swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

Published 20 hours ago • verified publisher icon swagger-api

add multi-arch docker build for linux/arm64/v8

Open mitjaziv opened this issue 2 years ago • 5 comments

PR checklist

  • [X] Read the contribution guidelines.
  • [X] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [X] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [X] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR adds multi-arch build with docker buildx to add support for Apple M1 machines.

Closes #11650

mitjaziv avatar Apr 22 '22 11:04 mitjaziv

@frantuma @HugoMario What do you think about this change? Could we release this with next version so swagger-codegen would be supported on M1 machines.

mitjaziv avatar May 17 '22 09:05 mitjaziv

This would be a very welcome change to our CI pipelines 👍

joaosa avatar May 19 '22 15:05 joaosa

Do you know when the first image will be available?

fellnerse avatar May 23 '22 14:05 fellnerse

For everyone who is waiting for this pull request in the meanwhile you can use this.

https://hub.docker.com/r/mitjaziv/swagger-codegen-cli https://github.com/mitjaziv/swagger-codegen

mitjaziv avatar Jun 26 '22 08:06 mitjaziv

Can one of the organization members take a look at this PR and merge it? @char0n @frantuma @gracekarina @HugoMario @ponelat

Dynehart avatar Sep 14 '22 17:09 Dynehart

Similar response to @Dynehart above. Could someone look into updating this PR and merging? Thanks!

joshmurrayeu avatar Oct 26 '22 10:10 joshmurrayeu

Bump, again. Could a maintainer take a look into this PR?

@char0n @frantuma @gracekarina @HugoMario @ponelat

joshmurrayeu avatar Oct 31 '22 16:10 joshmurrayeu

@mitjaziv I'm not a maintainer but I would recommend to make only the change that is required.

Replace docker build with docker buildx build --platform linux/arm64/v8,linux/amd64

They are probably too busy to understand the rest of the change. Even though I agree it should be done. They probably don't use shellcheck 🤷

andresvia avatar Nov 24 '22 00:11 andresvia

bump @char0n @frantuma @gracekarina @HugoMario @ponelat @HugoMario please, we really need this

wandergeek avatar May 17 '23 01:05 wandergeek

Bump Somebody please check & merge this PR. We really need this @char0n @frantuma @gracekarina @HugoMario @ponelat @HugoMario

repositarian avatar Oct 26 '23 15:10 repositarian

Hi folks, sorry for all the waiting. Will take a look into this. Thank you for your patience.

ponelat avatar Nov 15 '23 10:11 ponelat

Hi folks, sorry for all the waiting. Will take a look into this. Thank you for your patience.

I guess this is really old PR, and a lot was changed since it was opened, so I would need to re-investigate what needs to be changed, to fix pipelines.

mitjaziv avatar Nov 15 '23 11:11 mitjaziv

Thanks all for your patience, this has been replaced by the following changes adding multi-platform images builds:

#12290, #12291, #12292, #12293, #12294

similar changes are being applied to 3.0.0 branch

frantuma avatar Nov 28 '23 11:11 frantuma