swagger-codegen icon indicating copy to clipboard operation
swagger-codegen copied to clipboard

Published 20 hours ago • verified publisher icon swagger-api

11253: Update handlebars version

Open asdef opened this issue 3 years ago • 5 comments

PR checklist

  • [X ] Read the contribution guidelines.
  • [N/A ] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • [ X] Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • [ N/A] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Updated the handlebars version from 4.1.2 to 4.3.0 to pick up changes that add support for JDK 17 and address reflections issues in the earlier version that are visible in the maven codegen plugin.

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

asdef avatar Nov 08 '21 20:11 asdef

Can someone more experienced with this project help me understand the regression test failure? This change solves my specific problem with maven swagger code gen, but it's based on an assumption of JDK 17, and not JDK 9 as the regression test seems to be, both of which should have the breaking change around reflection that was made as part of JDK 9, or is it a problem in something unrelated?

asdef avatar Nov 08 '21 20:11 asdef

HI @asdef Thanks for fixing the handlebar vulnerability issue. I ran into the same with JDK 11 using maven swagger code gen plugin. Any idea when this would be merged?

viragtripathi avatar Nov 17 '21 05:11 viragtripathi

@viragtripathi

HI @asdef Thanks for fixing the handlebar vulnerability issue. I ran into the same with JDK 11 using maven swagger code gen plugin. Any idea when this would be merged?

I suspect the maintainers will accept it for merge after the failing test for php is addressed. I looked at it, but with zero PHP or handlebars experience, I'm not sure what's wrong with it. I'd appreciate any assistance you or anyone else can offer in classifying or fixing the failing test.

asdef avatar Nov 17 '21 18:11 asdef

Bump. Is this ever gonna be merged? Its important that this library can support latest versions of Java an Spring Boot. Thanks

Nachiten avatar Sep 03 '22 15:09 Nachiten

Is there a way to upgrade handlebars to 4.3.0 from a user gradle project that uses this swagger-codegen plugin?

nmarasoiu avatar Sep 21 '22 11:09 nmarasoiu