swagger-codegen-generators icon indicating copy to clipboard operation
swagger-codegen-generators copied to clipboard
verified publisher icon swagger-api

fix php enum allowable values delimiter generation

Open b3n3d1k7 opened this issue 1 year ago • 6 comments

Use last instead of hasMore in php model templates for allowableValues data arrays to fix missing delimiter

This fixes

  • https://github.com/swagger-api/swagger-codegen-generators/issues/1164
  • https://github.com/swagger-api/swagger-codegen/issues/12411

b3n3d1k7 avatar Dec 04 '24 07:12 b3n3d1k7

Any update on this merge? Thanks!

nicolabeghin avatar Feb 05 '25 21:02 nicolabeghin

Someone with merge permissions need to approve and merge it :/

andythedandy avatar Feb 06 '25 07:02 andythedandy

I'm having an issue with this bug as well would appreciate the merge / release.

drmmr763 avatar Mar 26 '25 18:03 drmmr763

I hit the same issue too. It would be helpful if this PR is merged.

katsew avatar Mar 31 '25 03:03 katsew

@frantuma

Sorry for the sudden mention but I saw you have merge permissions. Could you merge and release the fix? Currently I cannot generate the valid php model with the latest v3 docker image and this PR will fix it.

katsew avatar Apr 02 '25 02:04 katsew

We have the same problem here. As workaround we downgraded to swagger-codegen-maven-plugin version 3.0.44, which uses swagger-codegen-generators version 1.0.41, where enum generation works back then. We would appreciate it if you could review and approve this pull request.

Thanks

selimok avatar Apr 15 '25 03:04 selimok