sw360portal icon indicating copy to clipboard operation
sw360portal copied to clipboard

In generating License Info: Do not use found license if concluded not available

Open bs-jokri opened this issue 7 years ago • 4 comments

When a license info file is generated with spdx reports, it should be possible to disable found licenses if concluded licenses are available.

bs-jokri avatar Dec 11 '17 13:12 bs-jokri

The code for "disabling license info in file" is already preset, The corresponding flag is hard coded to true: https://github.com/sw360/sw360portal/blob/549d605c29dd9dbbdd39ebe15d8911c7e69eb2bd/backend/src/src-licenseinfo/src/main/java/org/eclipse/sw360/licenseinfo/parsers/SPDXParserTools.java#L98-L102

maxhbr avatar Dec 12 '17 10:12 maxhbr

I am not sure if the title is confusing, the second last word "not" should be skipped, right?

mcjaeger avatar Dec 13 '17 12:12 mcjaeger

Actually, how about letting the user choose what to generate? because I feel like many spdx document just have the found licenses and then concluded licenses are not well cared for.

mcjaeger avatar Jan 24 '18 16:01 mcjaeger

Hi, I am also considering this issue As I know. Currently, the code for "disabling license info in file" is already preset, the corresponding flag is hard coded to true. I wonder why the useLicenseInfoFromFiles flag is not controllable now. (Just not implemented, or other reasons?) I think we should make the flag controllable from sw360 interface Do you think about this?

truongtv-tsdv avatar Jan 26 '18 09:01 truongtv-tsdv