Shinji Watanabe
Shinji Watanabe
- @brianyan918, can you review it? - @jasonmusespresso, please add the results and config files. Also, please upload the model and put the link to the results.
See https://github.com/espnet/espnet/blob/master/egs2/aishell/asr1/README.md as a reference.
Also, see https://github.com/espnet/espnet/blob/master/CONTRIBUTING.md#132-espnet2-recipes
It looks good to me, but I want to have input from @brianyan918 @brianyan918, - can you confirm the change for `sacrebleu_opt_extra`? - compared with the other recipes, the README.md...
Thanks for your report. Which config file did you use?
Thanks. @soumimaiti, can you answer it?
@pengchengguo, could you answer it for me?
Sorry, it was not under my radar, as the TODO items are not marked. I'll start to review this.
@simpleoier, can you help review this PR, especially for the recipe template part?
@kan-bayashi, can you also review this PR? Since this PR touches the core algorithm part, I want your help.