Shinji Watanabe

Results 318 comments of Shinji Watanabe

Thanks for your PR, @iamanigeeit! Can you fix the CI error? https://github.com/espnet/espnet/actions/runs/7986631083/job/21807429857?pr=5670

@Fhrozen, can you review this PR?

> For `check_kaldi_symlinks`, does it mean that `copy_data_dir.sh` must be identical between `egs2/TEMPLATE/asr1/utils` and `tools/kaldi/egs/wsj/s5` ? Should I send a PR for kaldi to make them match? Yes, it should...

> It looks like the entire directory `egs2/TEMPLATE/asr1/utils` must be identical to `tools/kaldi/egs/wsj/s5`. In that case, i don't know where to add `copy_tts_data_dir.sh`. Can i just make the PR for...

Hi @iamanigeeit, I do not follow all conversations with @Fhrozen, but we have a CI issue in https://github.com/espnet/espnet/actions/runs/8048817075/job/21980956442?pr=5670#step:8:37 Can you fix it?

I think whisper is installed in our basic CI https://github.com/espnet/espnet/blob/master/ci/install.sh#L24, but probably it is too old?

> Should we still support Python 3.7? If so, i can amend the test script. Yeah, but it does not go through the CI test anyway due to `pytorch

Thanks for your request. @ftshijt, can you respond to this?

Thanks, @albertz. @kamo-naoyuki, can you answer it?

We can successfully update `typeguard`