Shinji Watanabe
Shinji Watanabe
What is the current status, @Some-random?
> 1 Would it be acceptable to place the scoring script in "espnet2.bin.vad_scoring"? OK, since SE is also doing the same thing. > 2 Can we forgo the use of...
@ftshijt, can you review this PR again? @Some-random There are some errors. https://github.com/espnet/espnet/actions/runs/5221471893/jobs/9425771502?pr=5156#step:18:103678 I recommend you check it locally in advance to avoid this type of error, especially for https://github.com/espnet/espnet/blob/master/ci/test_integration_espnet2.sh#L302-L309
Please fix https://github.com/espnet/espnet/actions/runs/5230271708/jobs/9443727951?pr=5156#step:12:103899
@Some-random, it’s almost there. So, can you reflect the comments?
@Some-random, this is a reminder.
@ftshijt, could I ask you to review this PR again? I think this becomes a good shape now.
@ftshijt, could you review this PR, again?
We do not fully maintain espent1 (although it may still work). I'd recommend you try espnet2
Thanks for the report. @kan-bayashi, can you check them?