django-progressive-web-app icon indicating copy to clipboard operation
django-progressive-web-app copied to clipboard

django 2, use template views, specify default_config

Open devkral opened this issue 6 years ago • 6 comments

Hello, I rewrote some of your code for django 2 support and cleaner solutions. My changes are:

  • add django 2 requirement and some fixes
  • use templateviews instead of own implementations (can use context stuff now in serviceworker.js)
  • add content_types
  • update README.md
  • add PWA_APP_FETCH_URL (later for my own serviceworker.js default implementation)
  • add default_config in __init__.py (sometimes required for finding the apps config) I can seperate the commit request if wished

devkral avatar Dec 23 '17 13:12 devkral

I didn't provide backward compatibility for django 1.11. Shall I change this?

devkral avatar Dec 23 '17 13:12 devkral

I will split out the serviceworker implementation in an own package (the django url tag makes the special parameter (PWA_APP_FETCH_URL) superfluous). See: https://github.com/devkral/django-pwa-batteries

devkral avatar Dec 28 '17 13:12 devkral

Hi @devkral, my apologies for taking so long to get to this. I'll try to get it reviewed within the next week. Thank you for taking the time to make these updates!

svvitale avatar Feb 01 '18 04:02 svvitale

no problem

devkral avatar Feb 01 '18 12:02 devkral

I'd like to pull in your django-pwa-batteries work since I think people will mostly want both. Would you be okay adding it to this module? And I'd also like to provide support to Django 1.11+ since that's the current LTS.

svvitale avatar Feb 01 '18 16:02 svvitale

sry, github ate my answer. I am ok with the pwa_battery stuff being pulled in. But be aware it is beta. It needs some tests and most probably bugfixes.

devkral avatar Feb 05 '18 08:02 devkral