memo icon indicating copy to clipboard operation
memo copied to clipboard

feat: add a configuration option for other file extensions

Open tshort opened this issue 2 years ago • 4 comments

This option allows the user to specify a list of "other" file extensions. These are in addition to Markdown and image files. This is an array. For the special case of ["*"], all files are supported, regardless of extension.

This partially fixes requests in #592 and #593.

I took a shot at a test, but I can't figure out how to run tests locally, so I don't know if it works. This option also needs to be documented.

tshort avatar Jan 27 '23 01:01 tshort

Thanks for contributing @tshort!

I took a shot at a test, but I can't figure out how to run tests locally, so I don't know if it works. This option also needs to be documented.

Let me know if this approach works for you: https://github.com/svsool/memo/blob/master/CONTRIBUTING.md#run-tests

svsool avatar Jan 28 '23 08:01 svsool

I've tried a few things, but I can't get yarn test to work. I'm seeing "Cannot find module '_isMockFunction'". Is there some extension I need to add?

Also, it doesn't look like the CI is running for this PR (Secret VSCE_PAT is required, but not provided while calling). Is there anything I need to do to enable that?

tshort avatar Feb 05 '23 20:02 tshort

I've tried a few things, but I can't get yarn test to work. I'm seeing "Cannot find module '_isMockFunction'". Is there some extension I need to add?

Also, it doesn't look like the CI is running for this PR (Secret VSCE_PAT is required, but not provided while calling). Is there anything I need to do to enable that?

Checked this locally as well and indeed there is an issue with tests in latest vscode version that will need some investigation.

Update: After some investigation I found that commenting this code makes tests run (needs a proper fix though), seems like require logic in latest vscode changed.

svsool avatar Feb 19 '23 12:02 svsool

Hi @tshort, tests should be fixed now, please rebase, update NodeJS to v16.14.2, reinstall packages and let me know if works.

I'd suggest also to add tests for ["*"] and [] cases.

svsool avatar Mar 04 '23 12:03 svsool