Sujit Madiraju

Results 36 comments of Sujit Madiraju

@aditi-pandit @czentgr made some changes and condensed the code, would appreciate if you could take another look when you can.

@majetideepak invalid TimestampTz strings are implicitly handled via the parsing functions used - `fromTimestampString()` and `getTimeZoneID()` both throw error upon invalid input.

@majetideepak Addressed your comments and added negative tests!

@majetideepak Please let me know if it all looks good!

Java seems to only support `1.0` and `2.0`, while C++ supports more granular versions. https://www.javadoc.io/doc/org.apache.parquet/parquet-column/1.10.1/org/apache/parquet/column/ParquetProperties.WriterVersion.html

@mbasmanova opened this PR to address [your comment regarding partial date input handling](https://github.com/facebookincubator/velox/pull/5974#issuecomment-1993677741). Turned out to be a simple fix, taken care of with a call to an alternate date...

@mbasmanova Thanks for the review. I won't lie, I was initially thrown off by that name myself - I agree that it's a bit misleading. Passing `false` for `isIso8601` is...

@mbasmanova Your concern was valid - when testing the change, I noticed that along with allowing partial date input, the flag I enabled also allows ISO date strings to include...

@mbasmanova Now that I think about it, adding to the enum wouldn't quite be sufficient, due to the way the cast function is structured. The function itself needs to be...