Sujit Madiraju
Sujit Madiraju
@mbasmanova would appreciate your thoughts on the above: > Sorry for the confusion - I think I better understand your point now about making `toIso8601()` a static function. Though I...
@mbasmanova Yes, that's my point - the existing value conversion methods for the Date type, in `Type.h`, are not static methods but instead are instance methods (`toString()`, `toDays()`). That's why...
@mbasmanova I've made all the changes - created `toIso8601()` as a static method and overloaded `toString()` to take in `TimestampToStringOptions` as an argument, so it can be called by the...
Rebased with main again, hitting a new fuzzer failure. Opened issue - https://github.com/facebookincubator/velox/issues/9192
@mbasmanova CI clean now.
Rebased and modified to use new type implementation.
@pedroerp would appreciate if you could take a look!
Rebased as my branch was a bit out of date, should take care of the build issues.
@aditi-pandit @majetideepak please take a look!
Rebased and modified to account for changes to `TimestampWithTimezone` type (https://github.com/facebookincubator/velox/commit/6fdaff75ba6ad61957b3fd60c31da4ffa1f2837a).