svix-webhooks icon indicating copy to clipboard operation
svix-webhooks copied to clipboard

Allow signature validation without timestamp tolerance enforcement

Open svix-frank opened this issue 3 years ago • 4 comments

Should keep it enabled by default, but we might want to allow custom tolerances or allow to disable the tolerance enforcement altogether.

Can be useful if you want to verify old payloads or if you have a bad clock.

svix-frank avatar Jul 10 '21 20:07 svix-frank

@svix-frank Would you let me know why this issue was closed, please?

We are in a situation where we need to use a custom tolerance. We are going to create a subclass of __verify_timestamp, but wondering why such a simple method is prefixed with double underscore. https://github.com/svix/svix-webhooks/blob/03ab8b993df6094329ac47f7e2f130fd53e8fc24/python/svix/webhooks.py#L67-L79

masahiro-yamamoto-rc avatar Apr 25 '24 00:04 masahiro-yamamoto-rc

Asking for the same tweak but for a different reason than OP: sometimes, things go bad in production and webhooks need to be retried for business reasons.

Ref: https://news.ycombinator.com/item?id=27823109

dimaqq avatar Apr 25 '24 05:04 dimaqq

I reopened it. No idea why it was closed, but at the very least it's useful for tests (if not a variety of other use-cases too).

Asking for the same tweak but for a different reason than OP: sometimes, things go bad in production and webhooks need to be retried for business reasons.

You should generate a new signature when you retry (Svix already does it).

tasn avatar Apr 25 '24 12:04 tasn

Sorry I mean to say “processing of web hooks received from a 3rd party”

dimaqq avatar Apr 25 '24 20:04 dimaqq

There's a function VerifyIgnoringTimestamp for this nowadays. Please let us know if we closed this in error.

svix-jplatte avatar Oct 30 '24 15:10 svix-jplatte