svix-webhooks icon indicating copy to clipboard operation
svix-webhooks copied to clipboard

Remove unwraps from non-test code in queue/redis

Open svix-dylan opened this issue 2 years ago • 2 comments

We had a lot of unwraps in our Redis-based queue implementation. This PR refactors them to be .expect()s where appropriate, or to bubble errors up to a calling function that catches them.

svix-dylan avatar Jul 07 '22 16:07 svix-dylan

Would love feedback on this. I've only done a cursory run through. Open questions include, in functions that call and catch errors from the migrate_ functions -- how do we want to handle these errors? Currently I'm just passing them to a trace::error!. But they are nonrecoverable, right?

svix-dylan avatar Jul 07 '22 16:07 svix-dylan

This was now fixed by @svix-james in another PR, no?

tasn avatar Aug 17 '22 13:08 tasn