svix-webhooks icon indicating copy to clipboard operation
svix-webhooks copied to clipboard

Support Redis Sentinel on Svix Server

Open tu-pm opened this issue 10 months ago • 3 comments

Feature Request

Motivation

Redis Sentinel is a common HA practice for a small production deployment of Redis, since it requires much less physical resources to ensure high availability compare to Redis Cluster. It'd be nice if Svix supports Sentinel as well.

Proposal

Alternatives

tu-pm avatar Apr 17 '24 03:04 tu-pm

@svix-james, what do you think?

tasn avatar Aug 01 '24 22:08 tasn

I know next to nothing about sentinel so am not positive offhand, but I'm sure it's doable. The library supports sentinel.

svix-james avatar Aug 06 '24 16:08 svix-james

Hi guys, I'm wondering if there is any more information on this? If the library supports Sentinel, perhaps it is simply a matter of the correct configuration. This is how other Redis libraries work.

andrewmatthews avatar Aug 16 '24 05:08 andrewmatthews

How about support for AWS ElasticCache ?

maintainer note: the author created a separate issue at https://github.com/svix/svix-webhooks/issues/1458

sanjaywinjit avatar Sep 30 '24 11:09 sanjaywinjit

@andrewmatthews We now have support for Redis Sentinel in main. It should be available in our next release. In order to try it, you'll need to at a minimum add these configuration parameters.

redis_dsn -- should point to a sentinel server sentinel_service_name -- the name of the sentinel service

I don't recommend this for production workloads at this point without a good amount of testing. It has been lightly tested on our end, and there are some upstream optimizations that need to be made in the redis library. I will try to work on that at some point.

Fixed by https://github.com/svix/svix-webhooks/pull/1472

svix-james avatar Oct 07 '24 14:10 svix-james