Scott Vinkle

Results 31 comments of Scott Vinkle

### `role="application"` To add to this, some screen readers have their own built-in arrow key commands. For example, when using [JAWS](https://www.freedomscientific.com/products/software/jaws/) or [NVDA](https://www.nvaccess.org/), using the arrow keys navigates and announces...

@elalish It wasn't; `role="img"` remains: [template.ts#L321](https://github.com/google/model-viewer/blob/3ea869714596143168064f565736882811739a83/packages/model-viewer/src/template.ts#L321). More details: https://github.com/Shopify/dawn/issues/868

@cdata Go for it. 👍

*Bad news:* without `position: absolute` the `.visuallyhidden` element adds space to the container. Demo: https://codepen.io/svinkle/pen/LjQJbZ /cc @joe-watkins @scottaohara @roblarsen

I mean, you _could_ apply a work-around to the extra space by specifying a container `width` and `height` but that's not realistic. 😕

@joe-watkins Interesting… @roblarsen I might suggest a roll-back on the latest merge until this is sorted. Having extra, visual space is worse than the read order bug, imo.

`float` is causing more/different spacing issues on the site I'm working on… I vote revert.

> Some apps will display the browser's default focus styles around the main element Thoughts on adding: ```css [tabindex="-1"] { outline: none; } ``` This is likely the only instance...

@jeryj, familiar with any of the links @nschonni mentioned above? Any other thoughts around setting something like this up?