J S
J S
As discussed, I haven't looked at the parser yet. One small observation - DocsScraper should be its own module and only importing/exporting things. No code definitions in there. Ie, ```julia...
On a separate note, I took it for a spin and parsed docs across several packages -- I haven't verified all in detail, but at least it runs across several...
Thanks for the PR! > weather_data_analyzer had to be leared that increasing trends means continuously increasing. Even forbidding allowing similar values. So < instead of =
> Maybe we could note that it is a "custom pignify where ..." Why custom pignify? This is the "wiki" definition and we even spell out the rules. IMO that's...
> It is great idea of course. It can be anyways, we just have to note to remove ambiguity in each case. I think we should be pragmatic. Let's specify...
Thanks for the PR! I'll review it properly later. The first reaction was that we won't need a custom index (to avoid duplication), but you might be right that it's...
Apologies for scattering comments all over! One thing, Pinecone should be relevant for "retrieve" step. It should need very little changed for `generate!` step (only `build_context` needs work because we...
Thank you for taking it thus far, Iulia! I hope to take it over and merge it, but I'm short on time these days, so it might take a while...
Thank you for looking into it! My understanding that Iulia was working on some changes to Pinecone as well, but I don't know any details. If we don't hear from...
Thank you. It’s not wrong but why change it? It’s a domain redirect so it should both work. Did you have any challenges? I tend to use the domain without...