SVG icon indicating copy to clipboard operation
SVG copied to clipboard

Support .net core 3.0 and 3.1

Open AraHaan opened this issue 4 years ago • 8 comments

Description

The project has issues on .NET Core 3.0 and 3.1; Also .NET Core 3.0 and 3.1 adds System.Drawing to the WindowsDesktop.App package which can be trapped to PackageReference in csproj with Conditions=.

Example data

NA

Used Versions

latest nuget; also with latest master branch. .NET Core 3.0 &3.1 is the versions I am using atm.

Note: I will see if I can get SVG to compile with netcoreapp3.0;netcoreapp3.1.

AraHaan avatar Mar 26 '20 15:03 AraHaan

I have just changed the svg project to .NET Core 5 and upgraded and modified for errors and have successfully made a build. Will test it on my previous 2.2 build projects now to see what issues are going to arise. If anyone wants a zip please ping me here. Cheers PM

pmvqbridge avatar Nov 20 '20 05:11 pmvqbridge

I have just changed the svg project to .NET Core 5 and upgraded and modified for errors and have successfully made a build. Will test it on my previous 2.2 build projects now to see what issues are going to arise. If anyone wants a zip please ping me here. Cheers PM

I'd like to take a look. can you send me the zip?

NoonKnight avatar Nov 20 '20 16:11 NoonKnight

Hi, NoonKnight, I will upload to a repo and you can download

pgmolloy avatar Nov 20 '20 18:11 pgmolloy

okay, great. thanks.

On Fri, Nov 20, 2020 at 2:00 PM PM [email protected] wrote:

Hi, NoonKnight, I will upload to a repo and you can download

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vvvv/SVG/issues/700#issuecomment-731351826, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGXN4W5FATP5AZOFNJHLJLSQ24DVANCNFSM4LUKW6JQ .

-- All bug free programs are trivial. All non-trivial programs have bugs.

NoonKnight avatar Nov 20 '20 19:11 NoonKnight

@pmready let us know when you have a PR ready.

tebjan avatar Nov 20 '20 19:11 tebjan

Download at https://github.com/pmready/svgzip/raw/master/svg.zip

pmvqbridge avatar Nov 20 '20 19:11 pmvqbridge

Please be aware I haven't used it yet so there could still be issues but it does build ok.

pmvqbridge avatar Nov 20 '20 19:11 pmvqbridge

The work done in #780 and #772 will enable building using dotnet Source/Svg.sln (on windows at least as the samples require that), or on other supported OS's by .NET you can build with dotnet Source/Svg.csproj

wieslawsoltes avatar Jan 05 '21 07:01 wieslawsoltes

netcoreapp3.1 is supported, however support for netcoreapp3.0 is not planned.

paulushub avatar Dec 29 '23 07:12 paulushub