Stefan Verhoeven

Results 34 comments of Stefan Verhoeven

The built-in error looks like this ``` Run SonarSource/sonarcloud-github-action@master with: projectBaseDir: . env: pythonLocation: /opt/hostedtoolcache/Python/3.9.4/x64 LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.4/x64/lib GITHUB_TOKEN: *** SONAR_TOKEN: /usr/bin/docker run --name a33c1dcd4548f200c468788768eac4a8105e4_c64152 --label 8a33c1 --workdir /github/workspace --rm -e...

Names of model are exposed in BMI functions. Model variables which are structs have been flattened into multiple variables.

@JaroCamphuijsen could you check if all variables have consistent names?

Following get_value fails: * [x] S(t), must be array of float instead of float * [x] mod, is a string while grpc4bmi only supports array of float/int/double, drop from get_value...

* [x] get_input_var_names, list * [x] get_output_var_names, list * [x] get_time_units, str * [x] get_time_step, float * [x] get_current_time, float * [x] get_start_time, float * [x] get_end_time, float * [x]...

* [x] set_value_at_indices, str, list, list * [ ] set_value, str, list, blocked due to https://github.com/eWaterCycle/grpc4bmi/issues/47

@JaroCamphuijsen could you check if all functions accept and return the correct data types?

I will have a look at it on 10 Jun 2021

I would suggest we to remove the conda building workflows from this repo as use https://anaconda.org/bioconda/matchms and their [build system](https://bioconda.github.io/contributor/build-system.html) for building and verifying. There are some things we can...

So if x=10 then each query would have the 10 best scoring references. Or the 10 best scoring query/reference pairs.