time-duration-picker icon indicating copy to clipboard operation
time-duration-picker copied to clipboard

Published 20 hours ago • verified publisher icon svenwiegand

Add Android Support Library support module

Open ZimM-LostPolygon opened this issue 7 years ago • 5 comments

  • Added support for Android Support Library via a separate dependent time-duration-picker-support library
  • Minor refactoring.
  • Removed .idea folder from the repo. It is not supposed to be under version control.

ZimM-LostPolygon avatar Jan 21 '18 17:01 ZimM-LostPolygon

Many thanks for your PR. Unfortunately I'm currently lacking time to dig into this. I'll come back later. Sorry.

svenwiegand avatar Jan 27 '18 05:01 svenwiegand

No problem. Thanks for making this great library. It is the only one that does exactly what I needed, and it works great.

ZimM-LostPolygon avatar Jan 28 '18 02:01 ZimM-LostPolygon

@svenwiegand any news here? Please note that the platform's native Fragment is deprecated and people are advised to use the support library version.

When trying to use your awesome library, I get a ClassCastException: mobi.upod.timedurationpicker.TimeDurationPickerPreference cannot be cast to android.support.v7.preference.Preference. I'm afraid in its current state, it is not really useful anymore to people.

Please consider reviewing this MR!

@kapalex Due to the above, I think we don't need a dedicated -support version anymore.

grote avatar Aug 08 '18 20:08 grote

@grote I'm not up-to-date with android development anymore. I understood your comment so, that the support-variant from this PR is the only variant we are need, as the other stuff is deprecated. Correct?

svenwiegand avatar Nov 01 '18 14:11 svenwiegand

Yes that's correct. You can of course still offer the old variant, if you want.

grote avatar Nov 03 '18 16:11 grote