rofi-calc
rofi-calc copied to clipboard
Error Message Color (basic implementation)
Added a way to customize the color of calculator error messages, as described in #85. Also added a bit of documentation for the new option.
Hm would it perhaps be more proper to use the theme colors? It might be unexpected for people to be able to customize everything via theming option but then have to use a cli flag for a single color.
That would probably be the ideal implementation, but as I said, I kind of don't know how to do it or where to start. Also, looking at the activity in #85, I get the impression that this is more of a niche feature anyway rather than something many users have been actively requesting. Maybe I find some time in the future to look deeper into this, but I haven't really worked with rofi source code before and am far from what one would consider skilled when it comes to C ...
Also, this is exactly the way -hint-welcome
and -hint-result
are currently implemented.
If we eventually find a way to customize -calc-error-color
through the config.rasi, then these could get reworked as well.
Since most people put their rofi command(s) into some hotkey daemon (e.g. sxhkd) anyway, I don't see why appending this (optional) property ~~to the already existing -no-show-match
and -no-sort
~~ would be a huge problem.
EDIT: -no-sort
is of course a rofi option and not plugin-specific but the two options are recommended in the README
also (completely unrelated to this issue/pr): -no-show-match
apparently doesn't exist (anymore) – is this the option that is/was supposed to suppress the search highlighting of history items? If that is the case, i guess this needs its own issue.