miniserve icon indicating copy to clipboard operation
miniserve copied to clipboard

Published 20 hours ago • verified publisher icon svenstaro

Packaging for Windows

Open nagromc opened this issue 3 years ago • 4 comments

Really nice application 👍

You should publish miniserve on Chocolatey and Scoop to facilitate the deployment and upgrades.

nagromc avatar Sep 19 '21 18:09 nagromc

I've requested this in scoop too https://github.com/ScoopInstaller/Main/issues/2679.

Dialga avatar Sep 23 '21 16:09 Dialga

While we're at it, it would be nice to add it to winget as well

aathif394 avatar Sep 26 '21 03:09 aathif394

This is now in scoop (thanks @Dialga) and I've looked into winget and choco but it seems like I'm going to need to maintain some kind of package file in the repo then. I'd be generally willing to do that (and to set up automation for pushing the package) if someone can do the initial work and make a PR with a nupkg file that'll build on Windows.

I've also documented the scoop way to install miniserve in the README. Overall, this is already pretty Windows-friendly with three ways to run it on Windows (Docker, direct exe and scoop). Do we need more? Let me know what you think.

svenstaro avatar Feb 06 '22 12:02 svenstaro

I only use scoop, but I'm sure it doesn't hurt to expand the number of ways to install miniserve on Windows, if someone sends in a PR.

Dialga avatar Feb 06 '22 12:02 Dialga

I just submitted winget package PR. but it is blocked by Winget's issue. (msvc build requires msvc redist as dependency. and it doesn't supported on winget for now. See microsoft/winget-pkgs#101652)

Also, there's automate github actions for winget. one of them is https://github.com/vedantmgoyal2009/winget-releaser Once winget solves the problem, It would be nice to use those actions for automatic release.

kimwonj77 avatar Apr 06 '23 00:04 kimwonj77

I'm fine with adding some automation for this, yes. Thanks for adding this to winget. Please make sure to make a follow-up MR to the README to document this new installation method. You could also try to add the action to the release workflow. :)

svenstaro avatar Apr 12 '23 03:04 svenstaro

@kimwonj77 Now that we're linking CRT statically, I think the issue should be unblocked. Could you check?

svenstaro avatar Apr 27 '23 16:04 svenstaro

@svenstaro I checked that in my local sandbox and yes, it works. (with latest build artifacts from github.)

With latest master build

With 0.23.0

I'm waiting for new release!

kimwonj77 avatar Apr 28 '23 01:04 kimwonj77

Super nice. Here's 0.23.2. Can we consider this issue done then?

svenstaro avatar Apr 28 '23 02:04 svenstaro

Maybe. At least https://github.com/microsoft/winget-pkgs/pull/103754 is merged. And we could automate the PR after all.

kimwonj77 avatar Apr 28 '23 03:04 kimwonj77

It's merged now and it works great on my windows machines! It's safe to close now.

Also, If you want to setup auto-release on winget packages, try using https://github.com/vedantmgoyal2009/winget-releaser However, it needs to use github account/token (as winget-pkgs are based on GitHub PR). If don't want to give the access to actions on your primary account, you can make some 'bot account' on github for this.

kimwonj77 avatar May 01 '23 01:05 kimwonj77

I might add the auto releasing thing. With scoop, I think someone updates the package manually with a PR. That seems to work rather well. Would that be possible in this case as well if I don't get to automate it? I will still look into it, however.

svenstaro avatar May 07 '23 02:05 svenstaro

Well, if someone keep interested in, package(s) will be updated (via manually or automatically by someone). It's like a third-party scoop packaging.

kimwonj77 avatar May 08 '23 02:05 kimwonj77

Thanks. At any rate, I think we can consider this particular request closed now. :)

svenstaro avatar May 08 '23 04:05 svenstaro