WinSlap icon indicating copy to clipboard operation
WinSlap copied to clipboard

winslap hardcodes the winget version it downloads

Open sdhnewman opened this issue 3 years ago • 5 comments

Thanks for creating such a useful tool! I rewrote this issue because I see that the version of winget being downloaded has been updated.

That said, winslap should really attempt to install the latest stable version. Hardcoding the winget version number means that the code will have to be kept up to date. In fact, the version it downloads now is already out of date and will fail to download before long.

I don't know enough about github to suggest a way to download the latest stable release, but I wonder whether installing winget indirectly using the App Installer in the store would be one way. An alternative would be to check to see if winget has already been installed, then check the version or use whatever the user has installed and hope for the best.

Anyway, thanks again!

sdhnewman avatar Jul 09 '21 18:07 sdhnewman

Hi, thank you for the suggestion. Indeed, the winget version to be downloaded and installed is hardcoded and can get outdated. Installing software in WinSlap should work again. I am leaving this issue open as 'enhancement' until I resolve the following things:

  • [x] WinSlap should not attempt to install winget (and possibly fail) if it is already installed
  • [ ] The winget version to be downloaded should not be hard coded

If anyone has an idea how I can solve the second point, I'd be grateful (help wanted). Right now, it seems that winget is only available through the Windows Store if the insider mode is activated and I think WinSlap shouldn't force this option upon the user.

svenmauch avatar Jul 11 '21 16:07 svenmauch

Chris Titus has a similar project, but I've found yours to be much more comprehensive.

He is also using winget for packages in this script: https://github.com/ChrisTitusTech/win10script/blob/master/win10debloat.ps1

idtczoli avatar Jul 13 '21 11:07 idtczoli

Hi, thank you for the suggestion. Indeed, the winget version to be downloaded and installed is hardcoded and can get outdated. Installing software in WinSlap should work again. I am leaving this issue open as 'enhancement' until I resolve the following things:

  • [ ] WinSlap should not attempt to install winget (and possibly fail) if it is already installed
  • [ ] The winget version to be downloaded should not be hard coded

If anyone has an idea how I can solve the second point, I'd be grateful (help wanted). Right now, it seems that winget is only available through the Windows Store if the insider mode is activated and I think WinSlap shouldn't force this option upon the user.

Thank you for your reply. I agree that insider mode should not be required. I wonder when that requirement will be listed. I'm not coding actively anymore, but I'll see what I can find out. :)

sdhnewman avatar Jul 13 '21 20:07 sdhnewman

https://github.com/microsoft/winget-cli/releases/latest/download/Microsoft.DesktopAppInstaller_8wekyb3d8bbwe.msixbundle

playday3008 avatar Sep 14 '21 21:09 playday3008

Winget is now pre-installed in Win10 21H2 and Win11. The upcoming version (WinSlap 1.7) will no longer try to install it over an existing installation. https://github.com/svenmauch/WinSlap/commit/9d496c9374ad928d3d9697a9b9c2bc994bf18a0b

I will leave this issue open for now, as the version is still hardcoded if winget is not installed.

svenmauch avatar Aug 12 '22 16:08 svenmauch