leon icon indicating copy to clipboard operation
leon copied to clipboard

Another parameter not removed (intercom.com)

Open serrq opened this issue 2 years ago • 5 comments

Original link:

https://go.intercom.com/UnsubscribePage.html?mkt_unsubscribe=1&mkt_tok=MjU4LUNMVy0zNDQAAAGO5bVgi6xyLUvLOJKBHFjiM55rXu-rgIhOZA8Heu6ujKSiErRxF4bPQ4iH3RwJShU21P-wiMs1kmfae2-Myc1R6PbRm-kwJo2MmahL9F0EQ4P6kes

Manually cleaned:

https://go.intercom.com/UnsubscribePage.html?mkt_unsubscribe=1

1000093081

serrq avatar Oct 19 '23 08:10 serrq

New sanitizers are currently blocked because I'm rewriting the internals of Leon.

svenjacobs avatar Nov 01 '23 14:11 svenjacobs

Does it really make sense to have a cleaner for a specific unsubscribe page of a service?

I think once the refactoring of Leon is done, where users can manually select parameters for removal, this sanitizer would not be required, right?

I would like to only add sanitizers that make sense for the broader audience. We already have quite a few sanitizers in Leon and with every sanitizer the complexity and maintenance of the app increases.

svenjacobs avatar Nov 05 '23 15:11 svenjacobs