routing-filter icon indicating copy to clipboard operation
routing-filter copied to clipboard

Won't work with Rails 6.1

Open Fodoj opened this issue 5 years ago • 5 comments

I gave it a try on Rails 6.1 RC and figured that due to this change: https://github.com/rails/rails/commit/437ab2031ea4660cb4e57dea3d912aca37363c7e, routing-filter gem won't work anymore. Sadly I don't have capacity to submit a PR, but at least this files need to be updated to support new object types (though most likely then it will break suppor for Rails <6.1):

  • lib/routing_filter/filter.rb
  • lib/routing_filter/adapters/rails.r

Fodoj avatar Nov 28 '20 12:11 Fodoj

@svenfuchs ~~I have a working solution for Rails 6.1 but before I create a PR for it, I wanted to see whether you're ok with making the following changes:~~

  1. ~~Release a new version (0.6.4) with the gemspec updated to restrict the rails version to '>= 4.2', '< 6.1'~~
  2. ~~Cut a new branch for Rails 6.1 with updated gemspec >= 6.1 and release a new version (1.0.0) to reflect backwards incompatibility.~~

Update: PR #76 supports Rails 6.1 and maintains backwards compatibility.

hasghari avatar Dec 24 '20 02:12 hasghari

#76 has been merged, I think we just need a new gem release!

geoffharcourt avatar Apr 01 '21 17:04 geoffharcourt

Thanks so much for #76! Looking forward to the new release.

adsteel avatar Apr 05 '21 19:04 adsteel

When will the new version with #76 release?

techvineet avatar May 15 '21 06:05 techvineet

Hey, thanks for merging #76! Anything I can do to help releasing a new version?

kennyadsl avatar Jun 24 '21 05:06 kennyadsl