Stop sirv before reloading rollup

Open ranjan-purbey opened this issue 4 years ago • 2 comments

Fixes https://github.com/sveltejs/template/issues/199

Rollup reloads the config on detecting changes in it. This should also restart the sirv server. But the current config keeps creating new instances of sirv on each reload without properly stopping the previous ones. This PR fixes that behaviour.

Jan 22 '21 18:01 ranjan-purbey

I'm not convinced that killing the process by spawning kill is the best way to go about this.

I've not noticed the template spinning up endless copies of sirv. that would indeed feel like an issue.

Feb 23 '21 16:02 antony

@antony You'll probably notice the issue if you try to edit and save rollbar config while the server is running as mentioned in the attached issue

Feb 23 '21 17:02 ranjan-purbey