svelte
svelte copied to clipboard
fix: improve types for props when using Client-side component API
fix for https://github.com/sveltejs/language-tools/issues/1578
In theory this is a breaking change. So maybe it needs to wait for version 5 of Svelte
.
Before submitting the PR, please make sure you do the following
- [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [x] Prefix your PR title with
feat:
,fix:
,chore:
, ordocs:
. - [x] This message body should clearly illustrate what problems it solves.
- [x] Ideally, include a test that fails without this PR but passes with it.
Tests and linting
- [x] Run the tests with
pnpm test
and lint the project withpnpm lint
Ah, didn't knew about this issue. I updated it to use null
instead.
The types are more restrictive, but you wouldn't have been able to pass something that doesn't conform to these types without the code at least breaking at runtime I think? So maybe it's not really a breaking change?