svelte icon indicating copy to clipboard operation
svelte copied to clipboard

fix: fix hint to match animation used in solution

Open chhotii-alex opened this issue 1 year ago • 1 comments

The code (both app-a and app-b) references the fly transition, but the hint mentions a different transition (fade). Probably less confusing for a newbie if the hint does not have this extraneous discrepancy. Fixed hint in description to match problem code.

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ ] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint

chhotii-alex avatar Jul 06 '23 13:07 chhotii-alex

This is the old tutorial. The new tutorial hosted on https://learn.svelte.dev is here: https://github.com/sveltejs/learn.svelte.dev/tree/main/content/tutorial/02-advanced-svelte/02-transitions/08-key-blocks

benmccann avatar Jul 06 '23 16:07 benmccann