svelte icon indicating copy to clipboard operation
svelte copied to clipboard

fix: transition slide not smooth with min height and min width

Open xxkl1 opened this issue 1 year ago • 0 comments

Before submitting the PR, please make sure you do the following

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with npm test and lint the project with npm run lint

closes: #8533

transition slide will become not smooth with min-height and min-width. https://svelte.dev/repl/90fdf9a3faa645aaa1e18201cf29e9cf?version=4.0.3

transition slide not smooth when with min height or min width.

I think we can set min-height or min-width to be 0 to keep slide smooth when run animation.

I didn't add a test case because I don't know how to test this case.

I'd be happy to add test cases, if any suggestions can be given.

xxkl1 avatar Jul 04 '23 15:07 xxkl1