svelte icon indicating copy to clipboard operation
svelte copied to clipboard

fix: dealt with var declarations in bracket issue

Open ngtr6788 opened this issue 1 year ago • 1 comments

"Successor" to #8442, fixes #6706 (because I closed it and deleted the branch)

This PR simplifies the solution done in the previous PR, up to date with version 4, and keeps most of the tests. However, I do not expect this PR to be merged, as per #8442, it is best to hold off until version 5. Therefore, this PR would be more of a reference for potential version 5 compiler output overhaul on how to solve this issue, so feel free to put this in One Day, I don't really mind.

HEADS UP: BIG RESTRUCTURING UNDERWAY

The Svelte repo is currently in the process of heavy restructuring for Svelte 4. After that, work on Svelte 5 will likely change a lot on the compiler aswell. For that reason, please don't open PRs that are large in scope, touch more than a couple of files etc. In other words, bug fixes are fine, but feature PRs will likely not be merged.

Before submitting the PR, please make sure you do the following

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with pnpm test and lint the project with pnpm lint

ngtr6788 avatar May 26 '23 23:05 ngtr6788

@ngtr6788 is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 26 '23 23:05 vercel[bot]

⚠️ No Changeset found

Latest commit: 167772585ef30d9abc00168e299c405e7f1caaf3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 06 '23 15:08 changeset-bot[bot]

Will close this issue because of Svelte 5

ngtr6788 avatar Dec 19 '23 01:12 ngtr6788