svelte icon indicating copy to clipboard operation
svelte copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

[fix] named slots breaks svelte-ignore comments

Open NidMo opened this issue 2 years ago • 3 comments

Fixes #8075

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with [feat], [fix], [chore], or [docs].
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with npm test and lint the project with npm run lint

NidMo avatar Dec 12 '22 03:12 NidMo

Thank you for your contribution! Could you please add tests?

baseballyama avatar Dec 12 '22 03:12 baseballyama

ok, OK, I will add tests

NidMo avatar Dec 12 '22 03:12 NidMo

Thank you for your contribution! Could you please add tests?

@baseballyama hey bro，I have added test, please help me code review.

NidMo avatar Dec 12 '22 05:12 NidMo

Thank you so much! LGTM!

I refactor a bit for production code. And I refactor the test code because we can do tests without depending on internal AST. (Then a test is more strong for a change)

Thanks for your optimization, brother. Next pr, I will improve the code and test.

NidMo avatar Jan 04 '23 02:01 NidMo