svelte icon indicating copy to clipboard operation
svelte copied to clipboard

[fix] Error assigning to a const while element swapping #7948

Open RaiVaibhav opened this issue 3 years ago • 1 comments

Fix #7964 currently for a case where the parent type is ArrayPattern code needs to check if the elements are of direct type MemberExpression or Identifier, in the case of MemberExpression there will be an Identifier check for the Object of the MemberExpression.

Before submitting the PR, please make sure you do the following

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with [feat], [fix], [chore], or [docs].
  • [x] This message body should clearly illustrate what problems it solves.
  • [x] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [x] Run the tests with npm test and lint the project with npm run lint

RaiVaibhav avatar Oct 21 '22 16:10 RaiVaibhav

Hi, maybe I could pick this up?

radiantly avatar Dec 15 '22 11:12 radiantly

@radiantly

Sorry for the late reply. It's ok for me!🚀

baseballyama avatar Dec 31 '22 12:12 baseballyama

@baseballyama is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Feb 23 '23 14:02 vercel[bot]

I fixed a bug and add tests.

baseballyama avatar Feb 23 '23 14:02 baseballyama