svelte
svelte copied to clipboard
fix: `beforeUpdate` called twice with bound reference
Fixes: https://github.com/sveltejs/svelte/issues/6016 Fixes: https://github.com/sveltejs/svelte/issues/3290
Before submitting the PR, please make sure you do the following
- [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- [x] Prefix your PR title with
[feat],[fix],[chore], or[docs]. - [x] This message body should clearly illustrate what problems it solves.
- [x] Ideally, include a test that fails without this PR but passes with it.
Tests
- [x] Run the tests with
npm testand lint the project withnpm run lint
This PR doesn't touch on the cases related to reactivity, please check the comment https://github.com/sveltejs/svelte/issues/6685#issuecomment-946685606
Thanks for the extra refactors! We'll have to wait and see if the other maintainers have an opinion on this update strategy.
@rmunn is this PR still valid?
@RaiVaibhav if you don't mind rebasing this PR, we hope to review the outstanding PRs in the coming weeks
Hey Ben McCann, unfortunately I am not with my laptop for few days, requesting you or anyone else to kindly continue from here
Thanks
On Wed, Feb 22, 2023 at 11:00 AM Ben McCann @.***> wrote:
@RaiVaibhav https://github.com/RaiVaibhav if you don't mind rebasing this PR, we hope to review the outstanding PRs in the coming weeks
— Reply to this email directly, view it on GitHub https://github.com/sveltejs/svelte/pull/6858#issuecomment-1439461203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFJ7CJT456NZPN2G3AJGWXTWYWP65ANCNFSM5GJBWBYQ . You are receiving this because you were mentioned.Message ID: @.***>
You can update it a few days from now. That will be fine
@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel.
A member of the Team first needs to authorize it.
Kindly let me know if I can still help
Thank you for the offer! Svelte 5 deprecates beforeUpdate/afterUpdate in favor of $effect.pre/$effect, which behave correctly. Therefore closing this PR.