svelte icon indicating copy to clipboard operation
svelte copied to clipboard

fix: Set element's value attribute to default empty string if nothing is provided

Open asvsfs opened this issue 4 years ago • 7 comments

fix: https://github.com/sveltejs/svelte/issues/4467

Before submitting the PR, please make sure you do the following

  • [ ] It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases, features are absent for a reason.
  • [x] This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • [x] Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • [x] Run the tests with npm test or yarn test)

asvsfs avatar Aug 05 '20 10:08 asvsfs

What issue is this related to? What is this intended to fix?

Conduitry avatar Aug 05 '20 12:08 Conduitry

What issue is this related to? What is this intended to fix?

@Conduitry Forgot to mention ! it is related to #4467

asvsfs avatar Aug 05 '20 18:08 asvsfs

can you rebase against master and make sure npm run lint passes? we just updated our eslint config to allow only single quotes

benmccann avatar Sep 30 '20 02:09 benmccann

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 26 '21 19:06 stale[bot]

Just a reminder that this PR would need a rebase

benmccann avatar Feb 23 '23 00:02 benmccann

@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Mar 02 '23 19:03 vercel[bot]

Looking at the compiler output, I think we should either remove the input.value = .. assignmed that happens in c() or adjust that one instead to use the set_input_value method. The way it's now is setting the value two times essentially.

dummdidumm avatar Mar 15 '23 14:03 dummdidumm