svelte icon indicating copy to clipboard operation
svelte copied to clipboard

docs: update banner images and README

Open Ocean-OS opened this issue 1 year ago • 12 comments

Fixes #13952, by updating the banner image, adding dark/light mode in the README, and updating the site section info.

Before submitting the PR, please make sure you do the following

  • [X] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [X] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [X] This message body should clearly illustrate what problems it solves.
  • [X] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • [X] Run the tests with pnpm test and lint the project with pnpm lint

Ocean-OS avatar Oct 27 '24 19:10 Ocean-OS

⚠️ No Changeset found

Latest commit: 7f8acb8a3705e1c9612f0d56e3a94596f0db1ef3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 27 '24 19:10 changeset-bot[bot]

pnpm add https://pkg.pr.new/svelte@13978

commit: 742a330

pkg-pr-new[bot] avatar Oct 27 '24 19:10 pkg-pr-new[bot]

This looks really nice, I am just wondering how it would look if you made the line width of the svelte logo slightly thicker. I am no designer, but the line could look a bit jagged or dotted on some displays.

Should be fixed, what do you think?

Ocean-OS avatar Oct 27 '24 20:10 Ocean-OS

That definitely made it a lot better, thx

realguse avatar Oct 27 '24 21:10 realguse

Why is there both a banner and banner_large version? Can't we just use the banner version? Then all references to that img will also be kept stable

dummdidumm avatar Oct 31 '24 08:10 dummdidumm

The banner_large versions are higher resolution, I'll delete the lower resolution ones and change the new ones to "banner"

Ocean-OS avatar Oct 31 '24 14:10 Ocean-OS

I made a change so that the banner in the README shows up even if the README is displayed on other sites (eg NPM) This will only work if the PR is merged, as it assumes the banners are available in the main repository (not my fork)

Ocean-OS avatar Nov 01 '24 22:11 Ocean-OS

preview: https://svelte-dev-git-preview-svelte-13978-svelte.vercel.app/

this is an automated message

Rich-Harris avatar Nov 06 '24 20:11 Rich-Harris

Playground

pnpm add https://pkg.pr.new/svelte@13978

github-actions[bot] avatar Nov 06 '24 20:11 github-actions[bot]

The Site section has been updated to reflect the changes made during the release of Svelte 5.

Ocean-OS avatar Nov 06 '24 20:11 Ocean-OS

These are nice changes, but I wonder if they're working. When I visit https://github.com/Ocean-OS/svelte/tree/main I get a dead image

benmccann avatar Nov 09 '24 00:11 benmccann

These are nice changes, but I wonder if they're working. When I visit https://github.com/Ocean-OS/svelte/tree/main I get a dead image

The image URLs will work if the PR is merged, as they use the URLs that the images would be at if they were in this repository, (where the images do not currently exist), so sites like NPM will display the images correctly.

Ocean-OS avatar Nov 09 '24 04:11 Ocean-OS

Shoot, I accidentally deleted the changes...

Ocean-OS avatar Dec 26 '24 22:12 Ocean-OS

That’s the worst, I do it all the time unfortunately, thats why you backup your computer

realguse avatar Dec 26 '24 22:12 realguse