svelte icon indicating copy to clipboard operation
svelte copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

fix: counterpart transition not cancelled (#11528)

Open Alia5 opened this issue 9 months ago • 4 comments

Fix: Counterpart transition not cancelled

Fixes: #11528

On transitions that have both directions, elements may get stuck on the "out" state, if the updating condition gets updated while the out transition is still running.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [x] Prefix your PR title with feat:, fix:, chore:, or docs:.
  • [x] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • [x] Run the tests with pnpm test and lint the project with pnpm lint

Alia5 avatar May 10 '24 00:05 Alia5

⚠️ No Changeset found

Latest commit: c2bf445916eb4cbff2ccb8c30fd488b46221382c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 10 '24 00:05 changeset-bot[bot]

@Rich-Harris Did you ever get a chance to see if this change is still relevant with all the refactoring that have happened to transitions since?

trueadm avatar Jun 27 '24 14:06 trueadm

nope, sorry

Rich-Harris avatar Jun 27 '24 15:06 Rich-Harris

The bug I was aiming to fix still exists in next.166 ¯\_(ツ)_/¯

Alia5 avatar Jun 28 '24 08:06 Alia5

Fixed By: https://github.com/sveltejs/svelte/pull/12389

Alia5 avatar Jul 12 '24 13:07 Alia5