svelte-subdivide icon indicating copy to clipboard operation
svelte-subdivide copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

svelte-subdivide v3 PR

Open saabi opened this issue 5 years ago • 9 comments

Not tested yet because compilation is being blocked by an apparent rollup-plugin-svelte unexpected 'nowarn' option bug.

Just opening the PR to possibly avoid somebody else doing the same work in the meanwhile. I'll add any fixes as soon as I can compile and test the upgrade.

Sorry if there's too much commit noise, I was just making sure I detailed my first foreign upgrade for clarity. Should I collapse it?

saabi avatar Mar 12 '19 08:03 saabi

rollup/rollup-plugin-svelte/issues/50

saabi avatar Mar 12 '19 14:03 saabi

1 out of 8 tests are passing so far. Something about fake mouse clicks hapenning before the DOM is ready (in some tests).

saabi avatar Mar 13 '19 01:03 saabi

Another bug seems to be in Subdivide.beforeUpdate() { createGroup() } and another in that Subdivide.layout is always set to defaultLayout.

saabi avatar Mar 13 '19 03:03 saabi

After the latest commits it's passing 23 out of 24 tests.

saabi avatar Mar 13 '19 18:03 saabi

Small woopsie, I bumped the version prematurely accidentally when uploading some changes to package.json

saabi avatar Mar 13 '19 18:03 saabi

In test #7, where the layout is passed to the constructor, it's creating the Panes in the wrong order internally, though geometrically everything's fine.

It seems one can only tell the difference with static vars, such as the static counter used in the tests that detects instancing order.

So it doesn't pass the test, but I'm not sure it would affect proper functioning in the end.

Also, I'm not sure I can control instancing order.

saabi avatar Mar 13 '19 18:03 saabi

Regarding the new test... something that instantiates a predefined layout and then clicks, creating new panes.

saabi avatar Mar 17 '19 03:03 saabi

really hope to see this working with the newest svelte :)

blurymind avatar Nov 28 '19 12:11 blurymind

here is my svelte layout component .... yay repl https://svelte.dev/repl/dea43257dc9c4236b99d4f51dbe222cd?version=3.24.1

im using a css flex layout, so its zoom agnostic resize is working 90% after only one day of coding : ]

the goal is to rewrite golden-layout.js in svelte with support for drag-and-drop, maximize, tabs, menus

another good example is qt dockable widgets

edit: yay github https://github.com/milahu/svelte-layout-resizable

milahu avatar Aug 25 '20 18:08 milahu