svelte-devtools icon indicating copy to clipboard operation
svelte-devtools copied to clipboard

fix: document head null error

Open leafOfTree opened this issue 1 year ago • 1 comments

This is to fix https://github.com/sveltejs/svelte-devtools/issues/232

Add check for document.head. If it's null, call appendChild on the event DOMContentLoaded

leafOfTree avatar Sep 24 '24 05:09 leafOfTree

Thanks for the PR! I've added some context in https://github.com/sveltejs/svelte-devtools/issues/232#issuecomment-2370838203 but it seems like we'll need to find another fix as this would effectively invalidate the injectImmediately setting. Perhaps we could try removing the setting altogether, but I'll need to check what behaviors was prevented by enabling it in the first place

ignatiusmb avatar Sep 24 '24 10:09 ignatiusmb

Thanks for this, #238 has been merged and should fix the issue

ignatiusmb avatar Nov 01 '24 10:11 ignatiusmb