sapper icon indicating copy to clipboard operation
sapper copied to clipboard

Flag to fail `sapper export` if it finds a 500 / 404

Open WaltzingPenguin opened this issue 6 years ago • 3 comments

Is your feature request related to a problem? Please describe. When you execute sapper export it will crawl the entire website and, if it finds a missing page or can't execute something, will export a matching 500 or 404 for a given path. This is shown in red on the console and a developer looking at this will almost certainly spot the issue and go fix it.

The problem is when this is part of an automated build and doesn't get developer eyeballs. sapper export still returns a success code and the entire build is marked as a complete, even though there is almost certainly an issue that needs to be fixed.

Describe the solution you'd like There should be a flag added to sapper export so that, if it encounters an error on any page, it will exit with an error code.

How important is this feature to you? This is quality of life improvement. Sufficient levels of automated testing would accomplish the same thing.

WaltzingPenguin avatar Sep 03 '19 20:09 WaltzingPenguin

I would LOVE this!!

aubergene avatar Nov 05 '19 15:11 aubergene

would go so far as to say this should be default with opt out flag

swyxio avatar Nov 05 '19 17:11 swyxio

+1. Also found a possible duplicate: https://github.com/sveltejs/sapper/issues/1488

kissge avatar Feb 01 '21 09:02 kissge