sapper icon indicating copy to clipboard operation
sapper copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

tweak part invalidation logic

Open njbotkin opened this issue 6 years ago • 2 comments
trafficstars

Fixes https://github.com/sveltejs/sapper/issues/835.

njbotkin avatar Sep 02 '19 17:09 njbotkin

Oh, hmm. It seems that the tests added in https://github.com/sveltejs/sapper/pull/691 actually enforce the overeager invalidation behaviour described in https://github.com/sveltejs/sapper/issues/835. I would argue that h2 should not be updated in these cases (https://github.com/sveltejs/sapper/blob/master/test/apps/basics/test.ts#L292-L308).

njbotkin avatar Sep 02 '19 19:09 njbotkin

I'm not sure if you have any interest in pursuing this PR still? I hadn't heard anything for awhile. We've moved our CI from Travis to Github, so it'd need to be rebased at a minimum. But maybe better just to try to make sure it works in SvelteKit at this point?

benmccann avatar Mar 25 '21 21:03 benmccann

SvelteKit 1.0 is now out and Sapper is deprecated, so I'm going to close this

benmccann avatar Jan 11 '23 16:01 benmccann