sapper-template icon indicating copy to clipboard operation
sapper-template copied to clipboard
verified publisher icon sveltejs

Adding meta description, apple-touch-icon, and maskable icon

Open edjw opened this issue 5 years ago • 4 comments

The current starting Sapper template has some things missing for a 100s Lighthouse score. This PR fixes those issues

edjw avatar Sep 07 '20 12:09 edjw

I am pretty sure you shouldn't set meta description in the template.html, because other routes cannot overwrite it with svelte:head. You end up with multiple meta description tags in your head.

mcmxcdev avatar Sep 07 '20 19:09 mcmxcdev

I am pretty sure you shouldn't set meta description in the template.html, because other routes cannot overwrite it with svelte:head. You end up with multiple meta description tags in your head.

Is the _layout.svelte file in /src/routes a better spot for that within a svelte:head block?

edjw avatar Sep 07 '20 20:09 edjw

You can test, but I still don't think it'd overwrite it. I think it's best to include in each individual route

benmccann avatar Sep 07 '20 20:09 benmccann

@edjw this PR will need to be rebased

benmccann avatar Mar 24 '21 17:03 benmccann