prettier-plugin-svelte icon indicating copy to clipboard operation
prettier-plugin-svelte copied to clipboard

Remove use of `concat()`

Open fisker opened this issue 3 years ago • 4 comments

Leftover from #223

fisker avatar Feb 08 '22 05:02 fisker

This would be a breaking change because older versions of Prettier (below 2.3 AFAIK) do not support using an array instead of concat - we therefore would need to bump peer dependency requirements. Does Prettier remove support for using concat now or why is this change needed?

dummdidumm avatar Feb 08 '22 08:02 dummdidumm

Ah, I misunderstood #223, it handles new concat(array) from core parsers, not removing concat().

I'm planning to remove concat() in Prettier v3.0.0, if you are going to support older versions of Prettier, we should keep them.

I got some time today, I was checking plugins listed on Prettier website, I thought it's better to help you remove use of concat() before we release v3 (we don't have a schedule yet, maybe longer than I expect).

Feel free to close.

fisker avatar Feb 08 '22 09:02 fisker

Thanks for the clarification! I'll keep this open as a reminder. As soon as Prettier 3.0 is released I'll remove concat and release a new major version of prettier-plugin-svelte 👍

dummdidumm avatar Feb 08 '22 11:02 dummdidumm

FYI: There is also an ESLint plugin can do this job, eslint-plugin-prettier-doc.

fisker avatar Feb 08 '22 11:02 fisker

Closing in favor of #334

dummdidumm avatar Dec 11 '22 20:12 dummdidumm