kit icon indicating copy to clipboard operation
kit copied to clipboard

Published 20 hours ago • verified publisher icon sveltejs

chore: form action tests debugging

Open dummdidumm opened this issue 2 years ago • 2 comments

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

dummdidumm avatar Jan 16 '23 17:01 dummdidumm

⚠️ No Changeset found

Latest commit: a5367beca23cce136d41fac0aaae3fc98709678f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jan 16 '23 17:01 changeset-bot[bot]

Hitting a wall here, this is super strange. According to the console logs, the enhance action is triggered, then fetch is called but nothing happens from that point on. It's as if fetch is a black hole with nothing happening from that point on. The await fetch is not resolved (I checked that the native fetch which we wrap is actually invoked), but there's no network call either. The only other lead I have is that this only happens for build. So maybe we should just turn these off when running in build mode (if that's possible)?

dummdidumm avatar Jan 17 '23 11:01 dummdidumm

I'm assuming we don't need this anymore since https://github.com/sveltejs/kit/pull/8585 was merged

benmccann avatar Jan 19 '23 22:01 benmccann