kit icon indicating copy to clipboard operation
kit copied to clipboard

docs: more build docs

Open dummdidumm opened this issue 2 years ago • 2 comments

Transforming the adapters document into a more general build doc Closes #8436

The alternative to this is to introduce another top level document (keeping the adapter doc as is) - I'm fine with that, too. Maybe I actually prefer that; opened #8501 for comparison

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [ ] This message body should clearly illustrate what problems it solves.
  • [ ] Ideally, include a test that fails without this PR but passes with it.

Tests

  • [ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

dummdidumm avatar Jan 13 '23 10:01 dummdidumm

🦋 Changeset detected

Latest commit: b5889181fbdf11805bb5243ad42e6e23d893623a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sveltejs/adapter-auto Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
create-svelte Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 13 '23 10:01 changeset-bot[bot]

I really hate that we have to bump the adapter packages everytime we update their docs. Maybe we should take this opportunity to move their docs from the READMEs to the docs folder?

That gives me another idea which would be to create a Building Your App section. Within that could live the new page, the general adapters docs, and docs for each individual official adapter.

benmccann avatar Jan 13 '23 14:01 benmccann

closing in favour of #8531

Rich-Harris avatar Jan 18 '23 02:01 Rich-Harris